Avoid taking control of UNUserNotificationCenter (Closes #206, closes #256)

[danielgindi]

There's a problem with the iOS >= 10 condition to set the delegate of the UNUserNotificationCenter.
What it does is take control of the UNUserNotificationCenter, and the user has no chance to change it back.
The effect is that every push notification also shows when the app is in foreground, which is undesired in most case.

This should be left to the user to define a delegate if he desires, and send the notifications to the foreground (and the logic in the delegate is defaulted anyway.)

Edit:
This also fixes Firebase notifications, as Firebase also registers for the delegate and take control from there.

[mauron85]

I see the motivation and agree those referenced issues should be resolved. But removing notification management it's not best way to do, because it will stop displaying debug notifications when app is in foreground. You can argue, "hey who is needing those", but my reply would be, we need a fix that target both issues.

[danielgindi]

Maybe we can enable those in debug mode only

[danielgindi]

Okay so I've changed it to be enabled in debug mode only - and also then - give FCM a chance. It keeps the previous delegate pointer.
If another module (like FCM) was loaded after this one, then it's out of our hands anyway and the delegate was overriden.

[mauron85]

Merged. Thank you!

[rudiminty]

@mauron85, has this been made available in an official version on npmjs for cordova-plugin-mauron85-background-geolocation?

[mauron85]

yes, not remember which version exactly, but check changelog

…

On Fri, Sep 14, 2018 at 5:06 PM rudiminty ***@***.***> wrote: @mauron85 <https://github.com/mauron85>, has this been made available in an official version on npmjs for cordova-plugin-mauron85-background-geolocation? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#268 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAV8GtEnUttrmyonYq_RJvO_2j3z9wG7ks5ua8X2gaJpZM4WDnI6> .

[rudiminty]

The reason why I ask is that I used 3.0.0 alpha 42 but still find that on iOS push notifications in the foreground are not handled correctly. Could this issue be responsible for such behaviour?