-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ASP.NET Core middleware #3
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ snazzy exception message.
Having the middleware options in the service bag is useful.
Primarily for internal purposes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new project named "Pidget.AspNet", along with some test projects. Foremost, it includes an
ExceptionReportingMiddleware
which captures exceptions thrown by the invocation of the request delegate, appends data captured from the request and then sends it to Sentry using the DSN provided in theExceptionReportingOptions
.Captured exception are then "silently" re-thrown, meaning a preceding middleware may be used to additionally handle thrown exceptions. It is intentionally written to not obfuscate the original exception thrown; just forward it.
The project also includes the dependency injection extensions
ConfigurePidgetMiddleware
, which are used to simplify configuration of the exception reporting middleware.Sentry also strongly suggests sanitizing request data on the client-side so support for this has been added and can be configured through the
SanitationOptions
property on theExceptionReportingMiddleware
.TODO:
Include JSON body data in event(upcoming feature)Deep JSON sanitizing(upcoming feature).