Capture environment variables 💯🎉 #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #41 +/- ##
========================================
+ Coverage 99.81% 100% +0.18%
========================================
Files 35 35
Lines 527 533 +6
========================================
+ Hits 526 533 +7
+ Misses 1 0 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had forgot to include an entire feature in the project, but it wasn't until the last percent of line coverage that I recognized that it was missing. Thanks codecov!— or code coverage tools in general, I suppose.
This PR includes capturing of environment variables from the static
Environmentobject. It also sanitizes them, just … in case you have some dirty secrets hidden in … your environment variables? 🤷♂️And of course, for realzies this time: 100% code coverage. 🎉