Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for outgoing knocks #105

Merged
merged 1 commit into from
Jun 22, 2022
Merged

add support for outgoing knocks #105

merged 1 commit into from
Jun 22, 2022

Conversation

maltee1
Copy link
Contributor

@maltee1 maltee1 commented Jun 18, 2022

I hope this works, I don't yet have code to test it with.
I'm not sure whether

  • the server list should be optional (I assumed so, because it also is on join_room)
  • there should be any retries (like for join_room)
  • there would be any extra_content

@maltee1 maltee1 force-pushed the outgoing_knocks branch 3 times, most recently from 252e089 to 9acc3e6 Compare June 22, 2022 18:23
@tulir tulir merged commit 571f721 into mautrix:master Jun 22, 2022
@maltee1 maltee1 mentioned this pull request Jun 22, 2022
Merged
@maltee1 maltee1 deleted the outgoing_knocks branch July 27, 2022 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tulir tulir tulir approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maltee1 @tulir