Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add basic create command #250

Merged
merged 16 commits into from
May 13, 2022
Merged

add basic create command #250

merged 16 commits into from
May 13, 2022

Conversation

maltee1
Copy link
Contributor

@maltee1 maltee1 commented Apr 19, 2022

There are still a few problems. I'm not sure if they are caused by or just triggered by my changes

  1. If I invite a ghost before running create, I will get a message that I already have a private chat with the user and the ghost leaves the room. I'm not sure how this is handled on the telegram bridge. IMHO, automatic dm creation should be limited to matrix rooms marked as direct. Inviting ghosts to rooms marked as rooms may trigger group creation in the future.
  2. if I invite a ghost when there are already users in the room, the ghost joins directly. Once I run create, that ghost leaves the room.
  3. I haven't been able to figure out where to obtain the matrix room's avatar url, so for now the room is created without an avatar.

member_role is currently set to DEFAULT. I suppose there isn't really a need to expose ADMINISTRATOR as an option. It's possibly somewhat related to a trusted private chat, but according to my understanding, the latter makes everyone who may join that room in the future automatically admin and the former only does that for the initial members. It's probably best to just map the power levels from the matrix side to signal

edit:
2 has changed with the fix for the invite implementation. The ghost still joins immediately but is no longer kicked. It also isn't added to the group upon group creation.

@maltee1
Copy link
Contributor Author

maltee1 commented Apr 20, 2022

OK, now it works

  1. shouldn't have anything to do with the implementation of the command
  2. works
  3. still doesn't work, but can be added later imho.

@maltee1
Copy link
Contributor Author

maltee1 commented Apr 25, 2022

Setting avatar now works. I suppose the create command is complete.

mausignald/signald.py Outdated Show resolved Hide resolved
mautrix_signal/portal.py Outdated Show resolved Hide resolved
mautrix_signal/portal.py Outdated Show resolved Hide resolved
mautrix_signal/commands/util.py Outdated Show resolved Hide resolved
maltee1 and others added 3 commits April 26, 2022 08:44
Co-authored-by: Sumner Evans <me@sumnerevans.com>
Co-authored-by: Sumner Evans <me@sumnerevans.com>
@maltee1 maltee1 requested a review from sumnerevans May 9, 2022 08:06
mautrix_signal/portal.py Show resolved Hide resolved
mautrix_signal/commands/signal.py Outdated Show resolved Hide resolved
mautrix_signal/commands/signal.py Outdated Show resolved Hide resolved
mautrix_signal/portal.py Outdated Show resolved Hide resolved
mautrix_signal/commands/signal.py Outdated Show resolved Hide resolved
Co-authored-by: Tulir Asokan <tulir@maunium.net>
@maltee1 maltee1 requested a review from tulir May 12, 2022 19:13
@tulir tulir removed the request for review from sumnerevans May 13, 2022 11:12
@tulir tulir merged commit 1be53a2 into mautrix:master May 13, 2022
@maltee1 maltee1 deleted the create_command branch May 13, 2022 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants