Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bridge Matrix -> Signal location #287

Merged
merged 1 commit into from
Jul 30, 2022
Merged

Conversation

maltee1
Copy link
Contributor

@maltee1 maltee1 commented Jul 26, 2022

Converts an m.location event to a map link in order to bridge it to signal. Let's you choose the map provider via config setting.
I ran into a bit of a problem with the different fields that provide additional information. content.body is supposed to be able to contain a description. Element just copies the content.geo_uri field there, which isn't adding anything of value, so it shouldn't be printed. content.body also contains relay sender information after the relay format is applied, so I can't exclude the field. I opted for removing the contents of geo_uri from body before prepending it, since that seemed to be the solution with the least amount of change.

This doesn't include msc3488. I'm not really sure how to account for that because I still need body in relay mode. But maybe we can worry about that when extensible events are out, since those would probably require changes to Portal.apply_relay_message_format anyway.

@tulir tulir merged commit 7ca3ce8 into mautrix:master Jul 30, 2022
@maltee1 maltee1 deleted the matrix_location branch July 30, 2022 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants