Add support for HPE Fortify code scanning during compilation #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctrueden
reviewed
May 11, 2017
| @@ -179,6 +179,8 @@ private void createLibrary(final Project antProject, final Library library) | |||
| if (getCpp() != null) { | |||
| final CompilerDef cpp = getCpp().getCompiler(Compiler.MAIN, null); | |||
| if (cpp != null) { | |||
| // Set FortifyID attribute | |||
There was a problem hiding this comment.
Please watch the whitespace. It does not match.
ctrueden
reviewed
May 11, 2017
| @@ -121,6 +121,16 @@ | |||
| @Parameter | |||
| private Java java; | |||
|
|
|||
| /* | |||
There was a problem hiding this comment.
Note that this is not javadoc, but should be. And note that javadoc is HTML, so line breaks mean nothing without <p> or <br> tags. Best is to use the IDE to preview the final result.
|
Thanks! I'm merging as is, and I'll do some minor cleanup on top of it. In the future, please check the diff of each commit very carefully. The better and cleaner they look, the faster we can merge things, for several reasons. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to use HPE Fortify to scan the C/C++ code, this scanning is done during compilation by adding prefix - sourceanalyzer -b
The way I implemented it was to use the new attribute existence as a flag that we need to use the Fortify prefix