Add support to xlC_r compiler on AIX #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctrueden
reviewed
May 22, 2017
| @@ -127,9 +127,7 @@ amd64.Windows.msvc.res.excludes= | |||
|
|
|||
| amd64.Windows.msvc.idl.compiler=midl | |||
| amd64.Windows.msvc.idl.defines= | |||
| amd64.Windows.msvc.idl.options= | |||
There was a problem hiding this comment.
Are these removals intended? If so, I think the commit message needs to explain how this is relevant to the addition of xlC_r. Same for the removal of the x86.Windows.gpp lines.
|
I just cleaned some duplication.... (You can still find these lines, now just in one place instead of 2) |
Ah, I see, OK. Great. If you can do such things as separate commits, that would be ideal, but in the interest of pragmatism I'll merge as-is. Thank you! |
|
Next time I promise a separate commit and PR....
Eyal
…On Tue, May 23, 2017 at 5:29 PM, Curtis Rueden ***@***.***> wrote:
I just cleaned some duplication
Ah, I see, OK. Great. If you can do such things as separate commits, that
would be ideal, but in the interest of pragmatism I'll merge as-is.
Thank you!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#279 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AKT4IYr515y3wG9O2yIYz3SllF_S_LMdks5r8u1EgaJpZM4Nhkcw>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for IBM xlC_r compiler for AIX