Convert to NPM module #70
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| { | ||
| "presets": ["es2015", "stage-0"] | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,96 @@ | ||
| { | ||
| "parser": "babel-eslint", | ||
| "env": { | ||
| "browser": true, | ||
| "node": true, | ||
| "es6": true | ||
| }, | ||
| "ecmaFeatures": { | ||
| "templateStrings": true, | ||
| }, | ||
| "rules": { | ||
|
There was a problem hiding this comment. In the interim, it would be nice (albeit counter to my point above) to pull in CoffeeLint to make that a requirement to pass before building our modules. There was a problem hiding this comment. That's on my checklist j just haven't put the checklist in the PR yet. There was a problem hiding this comment. Added to checklist in PR. |
||
| "strict": [0], | ||
| "brace-style": [1, "1tbs", {"allowSingleLine": true}], | ||
| "camelcase": 1, | ||
| "comma-dangle": [1, "never"], | ||
| "comma-spacing": [1, {"before": false, "after": true}], | ||
| "comma-style": [1, "last"], | ||
| "consistent-this": [1, "self"], | ||
| "curly": [2, "multi-line"], | ||
| "eqeqeq": [2, "allow-null"], | ||
| "eol-last": 1, | ||
| "guard-for-in": 0, | ||
| "indent": [2, 2], | ||
| "key-spacing": 0, | ||
| "new-cap": [1, {"capIsNew": false, "newIsCap": true}], | ||
| "new-parens": 0, | ||
| "no-bitwise": 0, | ||
| "no-cond-assign": 1, | ||
| "no-console": 1, | ||
| "no-constant-condition": 1, | ||
| "no-delete-var": 2, | ||
| "no-debugger": 1, | ||
| "no-dupe-keys": 1, | ||
| "no-duplicate-case": 1, | ||
| "no-empty-character-class": 1, | ||
| "no-eval": 1, | ||
| "no-ex-assign": 1, | ||
| "no-extend-native": 1, | ||
| "no-floating-decimal": 1, | ||
| "no-func-assign": 1, | ||
| "no-implied-eval": 1, | ||
| "no-inner-declarations": 1, | ||
| "no-invalid-regexp": 1, | ||
| "no-irregular-whitespace": 1, | ||
| "no-iterator": 1, | ||
| "no-labels": 1, | ||
| "no-lonely-if": 1, | ||
| "no-loop-func": 1, | ||
| "no-mixed-spaces-and-tabs": 1, | ||
| "no-native-reassign": 2, | ||
| "no-negated-in-lhs": 1, | ||
| "no-new-func": 1, | ||
| "no-new-object": 1, | ||
| "no-new-wrappers": 2, | ||
| "no-obj-calls": 1, | ||
| "no-octal": 1, | ||
| "no-plusplus": 0, | ||
| "no-proto": 2, | ||
| "no-redeclare": 1, | ||
| "no-return-assign": 1, | ||
| "no-self-compare": 1, | ||
| "no-sequences": 1, | ||
| "no-shadow": 0, | ||
| "no-spaced-func": 1, | ||
| "no-sparse-arrays": 1, | ||
| "no-throw-literal": 1, | ||
| "no-trailing-spaces": 1, | ||
| "no-unused-vars": [1, {"vars": "all", "args": "none"}], | ||
| "no-undef": 1, | ||
| "no-undefined": 2, | ||
| "no-undef-init": 1, | ||
| "no-underscore-dangle": 0, | ||
| "no-unreachable": 1, | ||
| "no-use-before-define": [1, "nofunc"], | ||
| "no-warning-comments": [0, {"terms": ["todo", "fixme"]}], | ||
| "no-extra-parens": 1, | ||
| "quotes": [1, "single", "avoid-escape"], | ||
| "quote-props": [0, "as-needed"], | ||
| "radix": 1, | ||
| "semi": [1, "always"], | ||
| "semi-spacing": [1, {"before": false, "after": true}], | ||
| "keyword-spacing": [2, {"before": true, "after": true}], | ||
| "space-before-blocks": [1, "always"], | ||
| "space-infix-ops": 1, | ||
| "space-in-parens": [1, "never"], | ||
| "space-unary-ops": [1, {"words": true, "nonwords": false}], | ||
| "use-isnan": 1, | ||
| "valid-typeof": 1, | ||
| "wrap-iife": [1, "inside"], | ||
| "yoda": 0, | ||
| "handle-callback-err": [1, "^(err|error)$"], | ||
| "no-mixed-requires": 1, | ||
| "no-new-require": 1, | ||
| "no-path-concat": 1 | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,12 @@ | ||
| .bundle/ | ||
| bin/ | ||
| lib/**/*.js | ||
| !lib/*.rb | ||
| tmp/ | ||
| .idea/ | ||
| pkg | ||
| .DS_Store | ||
| node_modules/ | ||
| tags | ||
| *.log | ||
| coffeelint.json |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| src/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,9 @@ | ||
| language: node_js | ||
| node_js: | ||
| - "5.1.1" | ||
| before_install: | ||
| - "export DISPLAY=:99.0" | ||
| - "sh -e /etc/init.d/xvfb start" | ||
| before_script: | ||
| - npm install -g gulp | ||
| script: gulp ci |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Realized the only BabelJS-flavored file we have is the gulp file. Are we planning on switching over the source files to ES6? If not, this does seem a little overkill (even though it is nice) since the majority of our source is CoffeeScript and it be nice to cut down on the dependencies that we need to pull in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah ultimately would like to switch to ES6... this is a subtle motivator :P