replace CircleCI with GitHub Actions #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthurlm44
reviewed
Aug 15, 2023
| end | ||
| subject.save! | ||
| rescue StandardError | ||
| nil |
There was a problem hiding this comment.
I would think the begin block is necessary here. Otherwise doesn't it always return nil?
There was a problem hiding this comment.
Rubocop actually made me change it to that. https://www.rubydoc.info/gems/rubocop/0.27.0/RuboCop/Cop/Style/RedundantBegin
There was a problem hiding this comment.
yea, there might be a special syntax case for rescue without begin...
you can also do stuff like
def thang(args)
# ... stuff that might raise exception
rescue ExceptionBit
# ... yadda
end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.