IE-539 Address Ruby 3 Changes to Kernel Behavior #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Nate Perry <nperry@mavenlink.com>
Co-authored-by: Nate Perry <nperry@mavenlink.com>
In Ruby 2, Kernel.open worked for both local and remote files. In Ruby 3, this was changed such that Kernel.open would only open local files. URI.open became the prefered syntax for opening remote files. ruby/open-uri@53862fa Co-authored-by: Nate Perry <nperry@mavenlink.com>
dezkowalski
commented
Mar 6, 2024
| @@ -1,3 +1,3 @@ | |||
| module QualtricsAPI | |||
| VERSION = "0.0.16".freeze | |||
| VERSION = "0.1.0".freeze | |||
There was a problem hiding this comment.
In this PR we did two things: 1. fix Kernel for Ruby 3 and 2. update bundler.
For the bundler update, we consider modern tooling compatibility to be a feature, hence we bumped a minor version instead of a patch version.
Co-authored-by: Nate Perry <nperry@mavenlink.com>
jarednielson
approved these changes
Mar 6, 2024
b6b
approved these changes
Mar 6, 2024
wilkinsondesouza
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Ruby 2, Kernel.open worked for both local and remote files.
In Ruby 3, this was changed such that Kernel.open would only open local files.
URI.open became the prefered syntax for opening remote files.
ruby/open-uri@53862fa
Bug ticket