Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy-Paste error in TelemetryImpl::process_fixedwing_metrics #1203

Closed
haydockjp opened this issue Oct 5, 2020 · 3 comments
Closed

Copy-Paste error in TelemetryImpl::process_fixedwing_metrics #1203

haydockjp opened this issue Oct 5, 2020 · 3 comments

Comments

@haydockjp
Copy link
Contributor

haydockjp commented Oct 5, 2020 •
edited
Loading

It looks like

    Telemetry::FixedwingMetrics new_fixedwing_metrics;
    new_fixedwing_metrics.airspeed_m_s = vfr_hud.airspeed;
    new_fixedwing_metrics.airspeed_m_s = vfr_hud.throttle * 1e-2f;
    new_fixedwing_metrics.airspeed_m_s = vfr_hud.climb;

Should be

    Telemetry::FixedwingMetrics new_fixedwing_metrics;
    new_fixedwing_metrics.airspeed_m_s = vfr_hud.airspeed;
    new_fixedwing_metrics.throttle_percentage= vfr_hud.throttle * 1e-2f;
    new_fixedwing_metrics.climb_rate_m_s = vfr_hud.climb;
@JonasVautherin
Copy link
Collaborator

Yes, good catch! It is fine in the proto definition: https://github.com/mavlink/MAVSDK-Proto/blob/master/protos/telemetry/telemetry.proto#L601-L603.

I assume you found that in telemetry_impl.cpp? Would you be willing to open a PR to fix that? 😊

@haydockjp
Copy link
Contributor Author

Yep

haydockjp added a commit to haydockjp/MAVSDK that referenced this issue Oct 5, 2020
@haydockjp
mavlink#1203 type in process_fixedwing_metrics impl
492ccae
@haydockjp
Copy link
Contributor Author

#1204

JonasVautherin added a commit that referenced this issue Oct 6, 2020
@JonasVautherin
Merge pull request #1204 from haydockjp/1203-FixedwingMetricsTypo
43bb5eb 
#1203 type in process_fixedwing_metrics impl
coderkalyan pushed a commit to coderkalyan/MAVSDK that referenced this issue Oct 8, 2020
@haydockjp @coderkalyan
mavlink#1203 type in process_fixedwing_metrics impl
a3fc987
coderkalyan pushed a commit to coderkalyan/MAVSDK that referenced this issue Oct 9, 2020
@haydockjp @coderkalyan
mavlink#1203 type in process_fixedwing_metrics impl
29b1115
coderkalyan pushed a commit to coderkalyan/MAVSDK that referenced this issue Oct 9, 2020
@haydockjp @coderkalyan
mavlink#1203 type in process_fixedwing_metrics impl
6aedbc7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@haydockjp @JonasVautherin