Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose full mission list #616

Closed
sanderux opened this issue Nov 30, 2018 · 12 comments
Closed

Expose full mission list #616

sanderux opened this issue Nov 30, 2018 · 12 comments
Labels
beginner A good issue for someone that only gets started

Comments

@sanderux
Copy link

We need access to the full mission list.
for this we would like to get a signal when the mission changed (finished uploading) and a way to read all items (not just then ones known to DC)

@julianoes

@julianoes julianoes added feature request beginner A good issue for someone that only gets started labels Nov 30, 2018
@JonasVautherin
Copy link
Collaborator

get a signal when the mission changed (finished uploading)

Is that in MAVLink? Say if I connect two instances from QGC and upload a mission from one, the other currently doesn't know about that, right?

a way to read all items (not just then ones known to DC)

I guess that would be a new "mission" plugin, as it probably doesn't fit in the current one (or does it?)

@hamishwillee
Copy link
Collaborator

get a signal when the mission changed (finished uploading)

You can get completion from the SDK upload_mission_async() but there is no MAVLink message to notify of a full mission upload: https://mavlink.io/en/services/mission.html

I guess that would be a new "mission" plugin, as it probably doesn't fit in the current one (or does it?)

It doesn't fit into the current plugin model of a "simple" API. Options are to add support for all types of mission item, to add an API to set or query the underlying mission params (ie allow a generic option for unknown params). I like the flexibility, but I bet @julianoes won't :-)

@julianoes
Copy link
Collaborator

I guess that would be a new "mission" plugin, as it probably doesn't fit in the current one (or does it?)

Yes I'd rather have some duplication than one complicated one with all the options that is just as hard as mavlink itself.

@hamishwillee
Copy link
Collaborator

IMO a reasonable compromise option might be to add a mission API to download/upload to file or text buffer using the standard plaintext format. Then anyone who wanted to be "clever" could manually edit and round-trip the file.

@JonasVautherin
Copy link
Collaborator

IMO a reasonable compromise option might be to add a mission API to download/upload to file or text buffer using the standard plaintext format. Then anyone who wanted to be "clever" could manually edit and round-trip the file.

My concern is that if we go down this road, we will quickly end up allowing "plaintext mavlink" a bit everywhere, and that's going against the SDK. We can try say "well, you can use that feature, but we may break it and we won't support you in using it", but people will probably still complain when it breaks, and they will still expect support for that.

I don't know, just a concern :-).

@hamishwillee
Copy link
Collaborator

I don't think this breaks the SDK, because the plaintext mission format is defacto standard for mission file storage/retrieval. Entirely up to you guys though. The alternatives are to my mind not as clean.

@JonasVautherin
Copy link
Collaborator

I see. Well that could be a possibility. @julianoes do you have an opinion on that?

@julianoes
Copy link
Collaborator

julianoes commented Dec 5, 2018

Yes, we could have a small plugin just to convert, and upload from/download to these mission format files.

@JonasVautherin
Copy link
Collaborator

Wouldn't that fit in the current mission plugin?

@julianoes
Copy link
Collaborator

Wouldn't that fit in the current mission plugin?

Not really because the mission items don't support all the settings and commands so then part of the file that you want to import is not supported which is actually the case right now as we already support the mission plan file.

@sanderux
Copy link
Author

sanderux commented Dec 6, 2018

Is that in MAVLink? Say if I connect two instances from QGC and upload a mission from one, the other currently doesn't know about that, right?

We now listen for MISSION_ACK to know if the mission was updated

@julianoes
Copy link
Collaborator

Done in #644.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginner A good issue for someone that only gets started
Projects
None yet
Development

No branches or pull requests

4 participants