Add mission raw plugin #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianoes
force-pushed
the
add-mission-raw
branch
from
a2c55f6 to
b39697b
Compare
julianoes
force-pushed
the
add-mission-raw
branch
4 times, most recently
from
d1799cf to
57a9990
Compare
| static constexpr double SOME_LONGITUDES[] = {8.545649, 8.545654}; | ||
| static constexpr float SOME_ALTITUDES[] = {5.0f, 7.5f}; | ||
| static constexpr float SOME_SPEEDS[] = {4.0f, 5.0f}; | ||
| static constexpr unsigned NUM_SOME_ITEMS = sizeof(SOME_LATITUDES) / sizeof(SOME_LATITUDES[0]); |
There was a problem hiding this comment.
Could we use a vector instead? Would be clearer to me 😕
| [&prom](MissionRaw::Result result, | ||
| std::vector<std::shared_ptr<MissionRaw::MavlinkMissionItemInt>> items) { | ||
| EXPECT_EQ(result, MissionRaw::Result::SUCCESS); | ||
| // TODO: validate items |
There was a problem hiding this comment.
That TODO is outdated, isn't it?
This will be a plugin which enables direct/raw access to MAVLink MISSION_ITEM_INT messages.
julianoes
force-pushed
the
add-mission-raw
branch
from
9d14008 to
aaa4a7e
Compare
|
I'm ignoring Jenkins because I don't know what he's trying to tell me. |
|
@JonasVautherin also I forgot to fix what you raised, I'll do that in #642. |
| /** | ||
| * @brief Mission item identical to MAVLink MISSION_ITEM_INT. | ||
| */ | ||
| struct MavlinkMissionItemInt { |
There was a problem hiding this comment.
No support for MISSION_ITEM?
There was a problem hiding this comment.
Nope. The SDK only does the new shiny things.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be a plugin which enables direct/raw access to MAVLink MISSION_ITEM_INT messages.
See progress here @sanderux.