Improve integration tests, add integration tests to CI #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianoes
force-pushed
the
improve-integration-tests
branch
3 times, most recently
from
c3ab360 to
8dc2b05
Compare
JonasVautherin
previously approved these changes
Jan 22, 2019
Merged
julianoes
force-pushed
the
improve-integration-tests
branch
from
d4a46e9 to
0c3867f
Compare
julianoes
force-pushed
the
improve-integration-tests
branch
from
3324fa3 to
0628cd7
Compare
|
Note to self: |
julianoes
force-pushed
the
improve-integration-tests
branch
3 times, most recently
from
f31fb29 to
c020c80
Compare
This was referenced Apr 30, 2019
julianoes
force-pushed
the
improve-integration-tests
branch
from
c020c80 to
430b9fa
Compare
This improves some printfs, makes sure flags used by different threads are atomic, and waits longer for altitude checks in order to pass them.
We shouldn't be doing a sync call inside a async call, therefore, we now move that to the thread pool.
This adds a simple helper that polls until a condition is true.
Instead of calling the callback directly on the receiver thread we are now using the thread pool which means that we don't block the receiver thread if the user does something involved in the callback. Also, by making a copy before passing the callback to the thread pool, we enable the subscription to cancel or change itself. For instance using `nullptr` a subscription can cancel itself again if it no longer needs updates.
This adds a helper function to check for a condition at 1/10 of the timeout until the timeout.
We should abort a test if we don't find a system.
Otherwise, we don't manage to land in time.
Eventually this `has_gimbal` check needs to be smart enough to know if there is a gimbal connected to the autopilot.
This way we don't report takeoff before actually doing it and we set the altitude before arming.
This needs to be replaced with the Path Checker.
This follows what the docs actually claim.
This adds a docker image with pre-built PX4 SITL.
julianoes
force-pushed
the
improve-integration-tests
branch
from
430b9fa to
a54fde9
Compare
julianoes
changed the title
julianoes
force-pushed
the
improve-integration-tests
branch
2 times, most recently
from
3d51cc8 to
aea5783
Compare
julianoes
force-pushed
the
improve-integration-tests
branch
from
aea5783 to
2dd5c3f
Compare
We only support the _INT protocol for missions. Therefore, we need to nack the non-_INT variant.
julianoes
force-pushed
the
improve-integration-tests
branch
from
b5ef6c8 to
f87b006
Compare
|
@JonasVautherin it's passing! Want to review? 😄 |
JonasVautherin
approved these changes
May 16, 2019
| LogWarn() << "Speed should be: " << speed_correct << " m/s, " | ||
| << "actually: " << speed_actual << " m/s"; | ||
| } | ||
| // TODO: enable these again with a better check not susceptible to time. |
There was a problem hiding this comment.
I guess we keep that disabled as well?
This was referenced May 16, 2019
This was referenced Jun 11, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we're able to enable all integration tests in CI we need to make sure they pass.
Addresses #639.