Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix comment, use lambdas for mission progress #104

Merged
merged 3 commits into from
Sep 27, 2017
Merged

fix comment, use lambdas for mission progress #104

merged 3 commits into from
Sep 27, 2017

Conversation

julianoes
Copy link
Collaborator

@julianoes julianoes commented Sep 27, 2017 •
edited
Loading

Thanks for spotting this @hamishwillee.

  • Fixed a wrong comment.
  • Changed mission progress handling into lambda because it is more readable.

@julianoes julianoes changed the title example: remove leftover comment fix comment, use lambdas for mission progress Sep 27, 2017
@hamishwillee
Copy link
Collaborator

@julianoes Looks good to me, but is out of date with base. Can you merge when you have a chance?

@julianoes julianoes merged commit a5c95c7 into develop Sep 27, 2017
@julianoes julianoes deleted the fix-mission-comment branch September 27, 2017 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamishwillee hamishwillee hamishwillee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julianoes @hamishwillee