Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

info: add vendor and product ID and name #118

Merged
merged 1 commit into from
Oct 17, 2017
Merged

Conversation

julianoes
Copy link
Collaborator

This adds the vendor and product ID and name back.

This adds the vendor and product ID and name back.
Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the change just because it is logical to separate product ownership from versioning? Makes sense to me.

@julianoes
Copy link
Collaborator Author

I guess it could also live in the same struct, you're right. But version is misleading for a vendor and product name.

@julianoes
Copy link
Collaborator Author

I'll merge this for now, we can always change it.

@julianoes julianoes merged commit f96c303 into develop Oct 17, 2017
@julianoes julianoes deleted the add-vendor-product branch October 17, 2017 14:39
@hamishwillee
Copy link
Collaborator

One bugger about this develop codeline approach is that it isn't clear when the changes are available in mainline/release - so nothing to trigger me to regenerate our API ref.

@julianoes
Copy link
Collaborator Author

I vote to get rid of develop and work on master and have releases of master.

@hamishwillee
Copy link
Collaborator

Me too. @mrpollo any objections to getting rid of develop and using releases of master? We can always create a release branch off master or just create a tag. If we find that managing development gets tough we can always add it back in again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants