Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PositionVelocity to offboard #1254

Merged
merged 3 commits into from
Nov 20, 2020
Merged

Conversation

JonasVautherin
Copy link
Collaborator

This adds a way to send a position and a velocity together, where the velocity is used as feed-forward.

@Jaeyoung-Lim: Does that seem correct?

Jaeyoung-Lim
Jaeyoung-Lim previously approved these changes Nov 13, 2020
Copy link
Contributor

@Jaeyoung-Lim Jaeyoung-Lim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I think it is a little implicit that yaw field in VelocityNedYaw will be ignored, but I think it is reasonable

@JonasVautherin
Copy link
Collaborator Author

Agreed, I will look into updating the API to improve that 👍.

@julianoes julianoes merged commit 6b7a2b6 into develop Nov 20, 2020
@julianoes julianoes deleted the offboard-positionvelocity branch November 20, 2020 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants