Cleanup #1270
Merged
Cleanup #1270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianoes
force-pushed
the
pr-cleanup
branch
from
b9e03d5
to
1705663
Compare
julianoes
force-pushed
the
pr-cleanup
branch
2 times, most recently
from
0697e16
to
015fffa
Compare
|
|
||
| This folder contains a few helper scripts meant to automatize some tasks such as packaging. | ||
|
|
||
| ### package_mavsdk_server_framework |
There was a problem hiding this comment.
This is outdated, but I'll update it in a further PR.
JonasVautherin
previously approved these changes
Dec 1, 2020
JonasVautherin
force-pushed
the
pr-cleanup
branch
from
302938c
to
eb220d7
Compare
JonasVautherin
previously approved these changes
Dec 1, 2020
JonasVautherin
previously approved these changes
Dec 2, 2020
Instead just print newlines and let the OS take care of when to flush. This should save some CPU cycles waiting for the flush.
This is because it throws warnings for the grpc generated headers and I can't manage to set the SYSTEM/-isystem flag correctly for these includes.
This is not actually required and was bad practice.
We can save the CPU cycles waiting for flushing and just use newlines only instead. This way the OS should take care of flushing.
This fixes the integration tests timing out because everything locks up as we're trying to lock the mutex twice in the offboard plugin, first to lock the data as we set it and then trying to send it.
|
CI error unrelated, merging. Otherwise this is going to conflict. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Best reviewed commit by commit.
Closes #1055, closes #1056.