Fix iOS simulator build following update to Xcode 12 #1278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Aaaand this breaks the libreSSL builds already. 😞 |
julianoes
force-pushed
the
update-ios-toolchain
branch
10 times, most recently
from
5164e7f
to
83ce613
Compare
JonasVautherin
force-pushed
the
update-ios-toolchain
branch
3 times, most recently
from
c0eb2be
to
daa570c
Compare
JonasVautherin
changed the title
JonasVautherin
force-pushed
the
update-ios-toolchain
branch
from
daa570c
to
93c0e15
Compare
julianoes
previously approved these changes
Dec 8, 2020
| @@ -335,6 +335,9 @@ if(USED_CMAKE_GENERATOR MATCHES "Xcode") | |||
| endif() | |||
| endif() | |||
|
|
|||
| # Required from Xcode 12 on, because it now builds for arm macbooks and we don't support that. | |||
| set(CMAKE_XCODE_ATTRIBUTE_EXCLUDED_ARCHS[sdk=iphonesimulator*] "arm64") | |||
There was a problem hiding this comment.
I was looking for that cmake argument but did not find it, nice!
There was a problem hiding this comment.
Yeah you were right on that from the beginning 💯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using latest version from https://github.com/leetal/ios-cmake