Add openssl #1281
Merged
Add openssl #1281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasVautherin
force-pushed
the
add-openssl
branch
from
2a95201
to
c28112b
Compare
|
For the env variables, probably worth trying this: |
JonasVautherin
force-pushed
the
add-openssl
branch
2 times, most recently
from
120a0b6
to
be9bc2e
Compare
julianoes
force-pushed
the
add-openssl
branch
from
d117376
to
adb6d25
Compare
|
@JonasVautherin what's special about these env vars? Can't you just do |
JonasVautherin
force-pushed
the
add-openssl
branch
8 times, most recently
from
6c98317
to
316c9e8
Compare
This reverts commit aa034df.
JonasVautherin
force-pushed
the
add-openssl
branch
from
e56e104
to
f48da41
Compare
JonasVautherin
force-pushed
the
add-openssl
branch
3 times, most recently
from
1d4a133
to
62710e6
Compare
JonasVautherin
force-pushed
the
add-openssl
branch
from
62710e6
to
4c6914f
Compare
JonasVautherin
force-pushed
the
add-openssl
branch
from
64021de
to
0b65eea
Compare
JonasVautherin
force-pushed
the
add-openssl
branch
2 times, most recently
from
185a01b
to
a1b14b7
Compare
julianoes
reviewed
Dec 10, 2020
| rpm-package: | ||
| name: ${{ matrix.container_name }} (package, non-mavsdk_server) | ||
| runs-on: ubuntu-18.04 | ||
| container: mavsdk/mavsdk-${{ matrix.container_name }} | ||
| strategy: | ||
| matrix: | ||
| container_name: [fedora-32, fedora-33] | ||
| container_name: [fedora-33] |
There was a problem hiding this comment.
Why only Fedora 33? My idea is to always have 2, so always the two versions that are supported.
There was a problem hiding this comment.
I did not manage to install perl-FindBin on Fedora-32, and eventually gave up 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because it's so much fun 😅.
More seriously, the reason for moving to OpenSSL instead of keeping LibreSSL is that we would want to use dTLS if we were to encrypt the MAVLink communications, and LibreSSL does not support dTLS.