Support to generate .deb packages #130

julianoes · 2017-10-23T20:45:08Z

This is a step towards integration tests for github.com/PX4/Firmware by generating .deb packages on releases.

In order to streamline the .deb generation, I've changed the build to a shared library for Linux and macOS, and made the default install location /usr/local.

While doing that I actually realized that libdronecore was not being linked to curl and pthread which required all executable to link against them. This should now be fixed.

hamishwillee · 2017-10-23T21:13:05Z

.travis.yml

+  provider: releases
+  skip_cleanup: true
+  api_key:
+    secure: hBX3pFWNZiDbz4yKnOjhLg3QS9Ubn1XePxSeIt2Btq5GzbomOPDCgpIFijBppliwj9oKc302EMnZSg2QWeAzFKn9UnmIflJ0E4iymYgwWdTJv+bSnYALJEmO8F6gF9FgRlPk8FCtZiECoTsa75w5TrEZKZpFpmzVYRiDu0eo6sEjW7UJPC0A2KSTXLrBCHSIZy/iasbGmuur4brG7NO0QdMOvDXvhsYfkXDRJFMTtTHvLiKJcqiunPfqARzf1H4x4iczRYscKu5Vn8Kmw3NANGkcIDvEj4ooih831EXxACRZw0VgycgNHOKRXKC9pZ4hLQMon+jxpQX+X8k/K5161oEkF/gCVKyFb31Pk/4Uwe81p1GJY2lAC7MDUxA98RKXhdvVYF2Cp44+IbF0YVoWRUtVAhknXRQ3Weg25kyVSu83q2nN2nZq2qGTnpNIbdN56s/F+uaFtipGEh+vmiv8rNUz+Z5MFrY2FQaSvBTFw9K4tNs9uc+VQd1bE7X5wh0yywEqUEw2nzqTB2xR+OubygUASbk2GLNdc254P0lrzCHbNM62Y7sRX06CM7hPlwhELEkVtUXZWJ0KuhQyLvRh3aPJ3Jj30EswTt/FGT1gzSP1FjjHBRZCK4P2D2rwJ5TMn2JrZKfPxmEd3kVmn6h80+gBbKgonGmZspd2SvPEI5g=


Probably a stupid question, but if this key is secure, why is it public here?

You only see the encrypted string. It's a common way with travis.
https://docs.travis-ci.com/user/environment-variables/#Defining-encrypted-variables-in-.travis.yml
But I appreciate that you check things like that!

hamishwillee · 2017-10-23T21:20:16Z

example/fly_mission/CMakeLists.txt

 add_executable(fly_mission
    fly_mission.cpp
 )

-# Not needed if DroneCore installed system-wide


Does the fact this is removed mean that you have sorted out Windows case for installing system wide?

I have currently no access to a Windows machine. I'll come back to the Windows build once I do.

So the plan is to do that before this is merged? It doesn't "matter" except that the example docs will need to be changed to add "not supported" for windows.

Ignore that, I see below that you're hopefully going to do that as part of this PR :-)

hamishwillee · 2017-10-23T21:21:18Z

example/fly_mission/CMakeLists.txt

 endif()

-# Add DEBUG define for Debug target
-set(CMAKE_CXX_FLAGS_DEBUG "-DDEBUG")


Release is built by default. Is this removed because we're happy for release build to be the default?

This is not actually about the default. All this does is it adds a #define DEBUG in case it is a debug build. This is not actually used or needed in the examples, so I removed it.

Thanks for the clarification.

hamishwillee · 2017-10-23T21:22:21Z

example/takeoff_land/CMakeLists.txt

-set(CMAKE_CXX_FLAGS_DEBUG "-DDEBUG")
-
-# This finds thread libs on Linux, Mac, and Windows.
-find_package(Threads REQUIRED)


So this isn't needed because now the underlying dronecore library links to the thread library?

hamishwillee · 2017-10-23T21:24:25Z

So looks good to me, but I haven't actually run it. Main questions are:

What happens on windows? Previously we supported only local install, but most of the local install stuff now pulled out of examples.
If system wide is supported as default, is there still a case for local install? ie is this something we need to document?
How do other things that previously installed to local system work - e.g. building docs.

coveralls · 2017-10-23T21:57:17Z

Coverage decreased (-34.7%) to 13.93% when pulling 9ef889f on release-deb into e12c969 on develop.

coveralls · 2017-10-23T23:59:23Z

Coverage decreased (-34.7%) to 13.93% when pulling 5cb25c9 on release-deb into e12c969 on develop.

coveralls · 2017-10-24T11:14:22Z

Coverage decreased (-34.7%) to 13.93% when pulling ccfc768 on release-deb into e12c969 on develop.

coveralls · 2017-10-24T11:41:17Z

Coverage decreased (-34.7%) to 13.93% when pulling c6538e7 on release-deb into e12c969 on develop.

coveralls · 2017-10-24T13:33:48Z

Coverage decreased (-34.7%) to 13.93% when pulling ecec1ba on release-deb into e12c969 on develop.

julianoes · 2017-10-24T14:16:46Z

What happens on windows? Previously we supported only local install, but most of the local install stuff now pulled out of examples.

I'll figure that out in the next days, probably as part of this PR even.

If system wide is supported as default, is there still a case for local install? ie is this something we need to document?

I think we can document that you can set the prefix where to install it. I'd leave it to devs to figure out how to link to it for that case.

How do other things that previously installed to local system work - e.g. building docs.

make docs works if you run it with sudo which is a little awkward, or we could have a script that builds locally and generates the docs there.

coveralls · 2017-10-24T18:51:52Z

Coverage decreased (-34.7%) to 13.93% when pulling 2be6a6d on release-deb into e12c969 on develop.

coveralls · 2017-10-24T21:09:21Z

Coverage decreased (-34.7%) to 13.93% when pulling d34c725 on release-deb into e12c969 on develop.

hamishwillee · 2017-10-24T22:50:26Z

If system wide is supported as default, is there still a case for local install? ie is this something we need to document?

I think we can document that you can set the prefix where to install it. I'd leave it to devs to figure out how to link to it for that case.

Sounds good. We can provide an example in docs.

How do other things that previously installed to local system work - e.g. building docs.

make docs works if you run it with sudo which is a little awkward, or we could have a script that builds locally and generates the docs there.

OK. Up to you. IMO having script is "nice to have", but hardly a priority. Worth adding an issue so it can be addressed at some later point.

hamishwillee · 2017-10-24T22:51:57Z

I'm good with this once Windows stuff addressed (by which I mean "fixed or explicitly not supported"), but leave @mrpollo to review.

julianoes · 2017-10-25T19:41:36Z

@hamishwillee ok agreed.

coveralls · 2017-10-31T22:38:55Z

Coverage decreased (-38.1%) to 17.017% when pulling f350a1c on release-deb into 09053c3 on develop.

coveralls · 2017-10-31T23:42:14Z

Coverage decreased (-38.1%) to 17.017% when pulling a3ba415 on release-deb into 09053c3 on develop.

coveralls · 2017-11-01T00:14:02Z

Coverage decreased (-38.1%) to 17.017% when pulling a3ba415 on release-deb into 09053c3 on develop.

coveralls · 2017-11-01T13:29:28Z

Coverage decreased (-38.1%) to 17.017% when pulling 219db58 on release-deb into 09053c3 on develop.

coveralls · 2017-11-06T17:28:43Z

Coverage remained the same at 17.571% when pulling 9fca987 on release-deb into d4688a2 on develop.

coveralls · 2017-11-06T21:46:32Z

Coverage remained the same at 17.571% when pulling 36b4505 on release-deb into 1b176f3 on develop.

This adds arguments for the Python script to set the input and output file paths. This enables to the script to be run a bit more flexible.

This moves the default install path to /usr/local. This is closer to the way that most projects are set up and alows for much easier examples.

We only need to link to libdronecore now because it is installed system-wide and the library is already linked to pthread.

libdronecore now already links to pthread.

This adds a script which can create a .deb package using checkinstall.

coveralls · 2017-11-07T23:38:28Z

Coverage remained the same at 17.571% when pulling bc3f32f on release-deb into 762c327 on develop.

julianoes requested review from mrpollo and hamishwillee October 23, 2017 20:45

julianoes force-pushed the release-deb branch from 1a57149 to 9ef889f Compare October 23, 2017 20:47

hamishwillee reviewed Oct 23, 2017

View reviewed changes

hamishwillee mentioned this pull request Oct 26, 2017

Fix up installation and example docs when 130 deb fix goes in mavlink/MAVSDK-docs#51

Closed

9 tasks

julianoes force-pushed the release-deb branch 6 times, most recently from 5125303 to a3ba415 Compare October 31, 2017 20:43

julianoes force-pushed the release-deb branch from a3ba415 to 507054d Compare November 1, 2017 12:27

julianoes force-pushed the release-deb branch from 219db58 to 9fca987 Compare November 6, 2017 15:41

julianoes force-pushed the release-deb branch from 9fca987 to 36b4505 Compare November 6, 2017 18:41

mrpollo approved these changes Nov 6, 2017

View reviewed changes

julianoes added 16 commits November 7, 2017 16:13

markdown script: remove trailing white space

9dd2275

markdown script: Add arguments for paths

293389a

This adds arguments for the Python script to set the input and output file paths. This enables to the script to be run a bit more flexible.

Makefile: move default install path to /usr/local

bef033e

This moves the default install path to /usr/local. This is closer to the way that most projects are set up and alows for much easier examples.

examples: cleanup CMakeLists.txt

1a9ee89

We only need to link to libdronecore now because it is installed system-wide and the library is already linked to pthread.

grpc: don't link to phtread anymore

86bcf36

libdronecore now already links to pthread.

Added script to create .deb package

124f42d

This adds a script which can create a .deb package using checkinstall.

travis: create .deb package and upload to github

825116f

travis: install locally where we don't have sudo

d2fe7a2

travis: try to install into /usr for gcc build

195cddc

travis: don't install and create docs without sudo

d96a243

travis: added script to run in docker

1e38b50

travis: correct fix_style make target

db05110

travis: clean up examples as well

13e8dac

appveyor: move to VS2017

ea6ff10

Makefile: we got rid of install target

2287e58

travis-docker-build: use proper syntax to install

bc3f32f

julianoes force-pushed the release-deb branch from 36b4505 to bc3f32f Compare November 7, 2017 21:14

julianoes merged commit 670b15f into develop Nov 8, 2017

julianoes deleted the release-deb branch November 8, 2017 18:50

This was referenced Nov 9, 2017

Install on ubuntu requires sudo after #130 #156

Closed

Example fails with library not found after #130 #157

Closed

Correct way to build external library after 130 #160

Closed

First draft of updates for #51 mavlink/MAVSDK-docs#62

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support to generate .deb packages #130

Support to generate .deb packages #130

julianoes commented Oct 23, 2017 •

edited

Loading

hamishwillee Oct 23, 2017

julianoes Oct 23, 2017 •

edited

Loading

hamishwillee Oct 23, 2017

julianoes Oct 24, 2017

hamishwillee Oct 24, 2017

hamishwillee Oct 24, 2017

hamishwillee Oct 23, 2017

julianoes Oct 24, 2017

hamishwillee Oct 24, 2017

hamishwillee Oct 23, 2017

julianoes Oct 24, 2017

hamishwillee commented Oct 23, 2017

coveralls commented Oct 23, 2017

coveralls commented Oct 23, 2017

coveralls commented Oct 24, 2017

coveralls commented Oct 24, 2017

coveralls commented Oct 24, 2017

julianoes commented Oct 24, 2017

coveralls commented Oct 24, 2017

coveralls commented Oct 24, 2017

hamishwillee commented Oct 24, 2017

hamishwillee commented Oct 24, 2017

julianoes commented Oct 25, 2017

coveralls commented Oct 31, 2017

coveralls commented Oct 31, 2017

coveralls commented Nov 1, 2017

coveralls commented Nov 1, 2017

coveralls commented Nov 6, 2017

coveralls commented Nov 6, 2017

coveralls commented Nov 7, 2017

Support to generate .deb packages #130

Support to generate .deb packages #130

Conversation

julianoes commented Oct 23, 2017 • edited Loading

Choose a reason for hiding this comment

julianoes Oct 23, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hamishwillee commented Oct 23, 2017

coveralls commented Oct 23, 2017

coveralls commented Oct 23, 2017

coveralls commented Oct 24, 2017

coveralls commented Oct 24, 2017

coveralls commented Oct 24, 2017

julianoes commented Oct 24, 2017

coveralls commented Oct 24, 2017

coveralls commented Oct 24, 2017

hamishwillee commented Oct 24, 2017

hamishwillee commented Oct 24, 2017

julianoes commented Oct 25, 2017

coveralls commented Oct 31, 2017

coveralls commented Oct 31, 2017

coveralls commented Nov 1, 2017

coveralls commented Nov 1, 2017

coveralls commented Nov 6, 2017

coveralls commented Nov 6, 2017

coveralls commented Nov 7, 2017

julianoes commented Oct 23, 2017 •

edited

Loading

julianoes Oct 23, 2017 •

edited

Loading