Initial hunter support #1391 #1393
Conversation
src/plugins/camera/CMakeLists.txt
Outdated
| @@ -9,7 +9,7 @@ target_link_libraries(mavsdk_camera | |||
| PUBLIC | |||
| mavsdk | |||
| PRIVATE | |||
| tinyxml2::tinyxml2 | |||
| ${TINYXML2_LIB_NAME} | |||
There was a problem hiding this comment.
Can't we use the targets with Hunter? I think that's the modern way...
There was a problem hiding this comment.
I am not against supporting Hunter on the principle, but I think it should work with minimal changes. Dropping the targets syntax for instance seems like a regression. And what if somebody comes tomorrow and wants to support a package manager that requires the target syntax?
My second question would be about keeping it separate: if Hunter could use the target syntax (tinyxml2::tinyxml2), it seems like this could all be done out of the project (somehow at the superbuild level), because it seems like all Hunter does is provide hunter_add_package and then override find_package. So ideally anything lower than the root (e.g. src/CMakeLists.txt) should not even know that Hunter is being used...
Does that make sense?
|
This said, we are applying a patch to jsoncpp 1.8.4, so it may not be the same as what Hunter provides. I looked into updating to 1.9.4 to be closer to upstream, and I think we would need this PR. That's mainly FYI, I'll try to update jsoncpp as soon as possible. Oh and tinyxml2 merged a PR to use the namespace, but did not release it: leethomason/tinyxml2#790. If it got released and used by Hunter, that may help, right? |
|
@bazfp FYI tinyxml2 is updated now. |
|
For the record I think that we would like to have leethomason/tinyxml2#866 and leethomason/tinyxml2#865 merged, and released in a new version of tinyxml. The @bazfp could maybe get that new version into Hunter? |
Can do, still waiting on jsoncpp release |
|
Update to this - seems upstream hunter has accepted @julianoes forked release of I will revisit this to confirm it builds with hunter |
|
@bazfp can we move on here or should we close this? I'm just trying to clean up stuff. |
Added a simple hunter support for getting dependencies. Builds fine here
The lib variables are a bit jank, but not sure what to do when the default cmake aliases them to something different than the actual library!
Build with
SUPERBUILD=OFF