gimbal: mutex fixes and added env variable for v2 #2298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pperpich
approved these changes
May 11, 2024
julianoes
force-pushed
the
pr-gimbal-fixes
branch
from
051ef7e
to
27d452c
Compare
- Make sure that _gimbal_protocol is also protected by the mutex. - Add MAVSDK_FORCE_GIMBAL_V2 to force usage of the gimbal v2 protocol and prevent the fallback to gimbal v1. This helps when we don't immediately detect all the components. - Keep trying to request the GIMBAL_MANAGER_INFORMATION message. Signed-off-by: Julian Oes <julian@oes.ch>
julianoes
force-pushed
the
pr-gimbal-fixes
branch
from
27d452c
to
d0b1e1c
Compare
There was a problem hiding this comment.
Instead of adding an env variable, why not just defaulting to V2 in case of timeout? I guess your problem now is that sometimes the init times out and it defaults to V1, right? But if V1 is presumably not used by anyone anymore, then V2 seems like a better default, and it would move the problem to those who use V1. What do you think?
|
|
@JonasVautherin that's a good idea. It's technically a break though as it changes the behavior somewhat unexpectedly. The problem is that we have no check to identify v1. Otherwise, we could indeed have a timeout on that. |
|
Oh, good point 😅. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With MAVSDK v3, I want to remove support for gimbal v1, it's just a pain.