Fix offboard plugin creation in example #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianoes
requested changes
Feb 6, 2018
| @@ -67,10 +67,8 @@ inline void offboard_log(const std::string &offb_mode, const std::string msg) | |||
| * | |||
| * returns true if everything went well in Offboard control, exits with a log otherwise. | |||
| */ | |||
| bool offb_ctrl_ned(Device &device) | |||
| bool offb_ctrl_ned(Offboard* offboard) | |||
There was a problem hiding this comment.
You're passing the smart pointer std::shared_ptr<Offboard> offboard here.
|
@julianoes Thanks, fixed. Should be good to merge now. |
julianoes
approved these changes
Feb 7, 2018
rt-2pm2
pushed a commit
to rt-2pm2/DronecodeSDK
that referenced
this pull request
Nov 27, 2018
Fix offboard plugin creation in example
dlech
pushed a commit
to dlech/MAVSDK
that referenced
this pull request
Jan 14, 2022
Add heading type to telemetry plugins
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass in offboard plugin instance rather than creating multiple shared pointers.