Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct Autopilot type of Self (GCS) #306

Merged
merged 1 commit into from
Mar 6, 2018
Merged

Conversation

shakthi-prashanth-m
Copy link
Contributor

@shakthi-prashanth-m shakthi-prashanth-m commented Mar 6, 2018

Fixes #305
Currently GCS type (in Heartbeat) is MAV_AUTOPILOT_GENERIC (its a type for autopilot! not for GCS).
However, MAVLink documentation recommends to use MAV_AUTOPILOT_INVALID for GCS.

Copy link
Collaborator

@julianoes julianoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right! Thanks for this fix.
Have you tested it in SITL?

Currently GCS type (in Heartbeat) is MAV_AUTOPILOT_GENERIC (its a type for autopilot!).
However, MAVLink documentation recommends to use MAV_AUTOPILOT_INVALID for GCS.
@shakthi-prashanth-m
Copy link
Contributor Author

Have you tested it in SITL?

Yes, I tested Takeoff land example on top of it. Thats enough I think. Isn't it ?

@julianoes
Copy link
Collaborator

Coveralls seems stuck, I'll ignore it for today.

@julianoes julianoes merged commit d19f0c8 into develop Mar 6, 2018
@julianoes julianoes deleted the fix-autopilot-type branch March 6, 2018 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants