Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for COMMAND_INT and abstraction for the same including COMMAND_LONG #351

Merged
merged 5 commits into from
Apr 9, 2018
Merged

Add support for COMMAND_INT and abstraction for the same including COMMAND_LONG #351

merged 5 commits into from
Apr 9, 2018

Commits on Apr 6, 2018

  1. core, plugins: Add support for COMMAND_INT #326 

    Adds new types `MAVLinkCommands::CmdInt` and `MAVLinkCommands::CmdLong`
types that abstract to those of MAVLink protocol:
http://mavlink.org/messages/common/#COMMAND_INT
http://mavlink.org/messages/common/#COMMAND_LONG

Also includes the changes in core and plugins, wherever these
commands are used. `COMMAND_INT` is used only in Gimbal plugin as of
now for `MAV_CMD_DO_SET_ROI_LOCATION`.
    Shakthi Prashanth M committed Apr 6, 2018
    Configuration menu
    Copy the full SHA
    9354ea0 View commit details
    Browse the repository at this point in the history

  2. core, plugins: Rename CmdInt -> CommandInt 

    MAVLinkCommands:CmdInt -> MAVLinkCommands::CommandInt
MAVLinkCommands:CmdLong -> MAVLinkCommands::CommandLong
    Shakthi Prashanth M committed Apr 6, 2018
    Configuration menu
    Copy the full SHA
    4e79d5d View commit details
    Browse the repository at this point in the history

  3. core, plugins: Correct param names of COMMAND_INT 

    In MAVLink spec for `COMMAND_INT` last 3 params are named as x, y and z.
Units of these would vary from meteres (Local pos) to degrees (Global pos).
Hence renamed as x, y and z.
    Shakthi Prashanth M committed Apr 6, 2018
    Configuration menu
    Copy the full SHA
    c67db7a View commit details
    Browse the repository at this point in the history

  4. Add "reserved_val" as argument to set_as_reserved() 

    Most of the "Reserved" values in MAVLink spec are NAN. However, in
some cases "Reserved" value could be "0". This utility method supplied
can be used to set any value to mark as "Reserved". For.eg: For commands
`MAV_CMD_LOGGING_START`, `MAV_CMD_LOGGING_STOP` etc, "Reserved" value is 0.
    Shakthi Prashanth M committed Apr 6, 2018
    Configuration menu
    Copy the full SHA
    e09ac5a View commit details
    Browse the repository at this point in the history

  5. core: plugins: Rename cmd -> command for consistency 

    Correct param name "reserved_value" in set_as_reserved().
    Shakthi Prashanth M committed Apr 6, 2018
    Configuration menu
    Copy the full SHA
    eeece31 View commit details
    Browse the repository at this point in the history