-
-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serial connection support for macOS #372
Conversation
@julianoes This concerns me - I was not aware that any of our APIs were "platform specific". If we don't support an API on a particular platform then that should be part of the documentation. So does this work on Windows? Are there any other APIs that we know only work on Linux, Windows or Mac? |
@hamishwillee: For what I understand from the code, the serial connection is now supported on Linux and macOS, and not on Windows. |
Thanks. Then we should probably add a warning to
I am making the assumption that everything else works everywhere. |
I wouldn't know 😀. |
@hamishwillee you're right. UDP and TCP connections are supported on all 3 operating systems. |
This is needed for some ifdefs in the serial connection.
This fixes a bug introduced in #372. By adding macOS support for serial, I had accidentally removed setting the baudrate for Linux.
This fixes a bug introduced in mavlink#372. By adding macOS support for serial, I had accidentally removed setting the baudrate for Linux.
Serial connection support for macOS
It recently came up on Slack that it would be good to have support for the serial connection on macOS.