third_party: use fork of json11 so that it builds as a static lib #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What do you mean with that? Do we need to change it for our purposes? |
|
Well, we need it static for iOS. And there is no argument in their CMakeLists for that, so it gets built as a shared library. In the fork, I make it STATIC, but the real fix would be to have an argument allowing to choose that, I believe. |
|
Yeah sorry my description was very unclear. I updated it :-). |
|
Ok, makes sense! |
julianoes
approved these changes
May 2, 2018
rt-2pm2
pushed a commit
to rt-2pm2/DronecodeSDK
that referenced
this pull request
Nov 27, 2018
third_party: use fork of json11 so that it builds as a static lib
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iOS needs json11 to be built statically, and it is not made for choosing the library type in a straightforward way. So for now I just forked it and added the "STATIC" keyword. I'll try to fix that on their CMakeLists.txt and make a PR.
NOTE: locally, I had to run
git submodule update --init --recursive --remotefor the change to take effect.