core: fix macOS warning #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
core/thread_pool_test.cpp
Outdated
| // an implicit capture. However, this makes clang sad, so we have to | ||
| // ignore its warning. | ||
| #if defined(__clang__) | ||
| #pragma clang diagnostic ignored "-Wunused-lambda-capture" |
There was a problem hiding this comment.
Why not doing that at the CMake level?
There was a problem hiding this comment.
I wasn't sure whether to apply this everywhere. I was hoping it only ever comes up here.
There was a problem hiding this comment.
As you want :).
As a principle, I don't like macros in the code, and I prefer to keep my code independent from the build system (as much as possible). But I'm fine with this as well.
JonasVautherin
approved these changes
May 30, 2018
julianoes
force-pushed
the
fix-mac-warning
branch
from
fadcfb4 to
eb69614
Compare
|
Note that you've changed it only for AppleClang, now (not sure if it is necessary for Clang, too). |
You're right: |
julianoes
force-pushed
the
fix-mac-warning
branch
from
eb69614 to
72f8b1d
Compare
Clang and MSVC are not agreeing on this issue. MSVC complains about an implicit capture while Clang says it's an unused lambda capture. For now, we'll ignore the Clang warning.
julianoes
force-pushed
the
fix-mac-warning
branch
from
72f8b1d to
0d81799
Compare
rt-2pm2
pushed a commit
to rt-2pm2/DronecodeSDK
that referenced
this pull request
Nov 27, 2018
core: fix macOS warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clang and MSVC are not agreeing on this issue, so we'll ignore
the clang warning for now.