Add plugin warnings #439
Merged
Add plugin warnings #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By oversight we did not have the special warnings enabled for the plugins.
JonasVautherin
approved these changes
Jul 6, 2018
| @@ -330,7 +330,7 @@ void CalibrationImpl::process_statustext(const mavlink_message_t &message) | |||
| // FALLTHROUGH | |||
| case CalibrationStatustextParser::Status::CANCELLED: | |||
| _calibration_callback = nullptr; | |||
| _state == State::NONE; | |||
| _state = State::NONE; | |||
plugins/telemetry/telemetry.cpp
Outdated
| std::numeric_limits<float>::epsilon() && | ||
| abs(lhs.velocity.north_m_s - rhs.velocity.north_m_s) <= | ||
| fabs(lhs.position.east_m - rhs.position.east_m) <= |
We need to reserve one char for null termination.
We want to try to avoid to use abs/fabs and instead use std::abs/std::fabs.
JonasVautherin
approved these changes
Jul 6, 2018
| #ifdef WINDOWS | ||
| #ifndef _USE_MATH_DEFINES | ||
| #define _USE_MATH_DEFINES | ||
| // Instead of using the constant from math.h or cmath we define it ourselves. This way |
| MAVLinkParameters::ParamValue value; | ||
| value.set_uint32(mavlink_camera_mode); | ||
| value.set_uint32(uint32_t(mavlink_camera_mode)); |
There was a problem hiding this comment.
What about static_cast<uint32_t>(mavlink_camera_mode)? Looks more modern to me 😅
|
I'm merging this and ignoring the jenkins CI for the branch. I think it fails because it greps for warning which is the name of the branch and therefore triggers when it should no. |
rt-2pm2
pushed a commit
to rt-2pm2/DronecodeSDK
that referenced
this pull request
Nov 27, 2018
Add plugin warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By oversight we did not have the special warnings enabled for the plugins.
This enables the warnings again and fixes a few that crept in. And one was actually a bug so that confirms that warnings are important!