Fix settings notification again #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves the issue where the current settings were not notified after color mode was updated. This happened because color mode does not lead to any other setting changes except the color mode itself. In this case `get_unknown_params()` would not find any unknown params but still return true. The right solution is to get rid of the confusing return argument and just check the size of the params vector directly.
|
@JonasVautherin I'm gonna release the backend 0.2.5 and test it. |
|
Tested, works. |
rt-2pm2
pushed a commit
to rt-2pm2/DronecodeSDK
that referenced
this pull request
Nov 27, 2018
…on-again Fix settings notification again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves the issue where the current settings were not notified
after color mode was updated. This happened because color mode does
not lead to any other setting changes except the color mode itself.
In this case
get_unknown_params()would not find any unknown paramsbut still return true. The right solution is to get rid of the confusing
return argument and just check the size of the params vector directly.
This is the correct fix instead of #524.