Some follow-me fixes #566
Merged
Some follow-me fixes #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the follow me path to just a simple square. Also, this fixes a previous bug where it rushed through the locations too quickly because each if would increment count_.
Otherwise we land before the follow me action has been done.
Flying lower and especially behind makes it more obvious what is happening.
We only need the placeholder once, `using namespace` is not really needed.
hamishwillee
approved these changes
Oct 1, 2018
|
It's a weird square but that's because it tries to be behind the target which makes it sway in the corners, I believe. |
JonasVautherin
approved these changes
Oct 1, 2018
| } | ||
| sleep_for(seconds(1)); | ||
| ++count_; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #408 and makes the example a bit easier to understand. The path is changed from a semi-circular path (which I had broken in the meantime) to just a square. Also, we're now following from behind which is most intuitive to start with.