Fix mission progress if mission is only downloaded #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We forgot to update the mavlink mission item to mission item map which meant that the mission progress was unknown (-1) in case the mission is only downloaded but never uploaded.
RTL is connected to the last mission item and does not require an additional step in the mission progress info. The off-by-one error was due because we increment item_i at the end of a loop iteration, although that's not required in the last iteration.
JonasVautherin
previously approved these changes
Oct 25, 2018
JonasVautherin
approved these changes
Oct 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a problem where the mission progress is just -1 if the mission has only been downloaded and never uploaded. The fix makes sure that the map between mission items and mavlink mission items is populated on download.