Fix camera status race #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianoes
previously approved these changes
Oct 26, 2018
JonasVautherin
force-pushed
the
fix-camera-status-race
branch
from
af9697a to
36ad431
Compare
julianoes
previously approved these changes
Oct 26, 2018
This was a copy&paste mistake.
julianoes
approved these changes
Oct 26, 2018
JonasVautherin
commented
Oct 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a race condition that made the backend crash when the CameraStatus stream was closed by the client. This seems to solve it (or at least makes it much more robust, as I couldn't reproduce the crash anymore).