Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backend: fail fast when dependency build fails #604

Closed
wants to merge 1 commit into from

Conversation

JonasVautherin
Copy link
Collaborator

So that people don't have to scroll up to find the error message when the build fails.

julianoes
julianoes previously approved these changes Nov 22, 2018
Copy link
Collaborator

@julianoes julianoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good but still we need to get the instructions right.

@JonasVautherin
Copy link
Collaborator Author

And somehow it fails on the CI.

@JonasVautherin
Copy link
Collaborator Author

Well it consistently fails on Jenkins, and the other PR passed. Somehow I'm doing it wrong.

@JonasVautherin JonasVautherin deleted the cmake-fail-fast branch November 22, 2018 16:27
@JonasVautherin JonasVautherin restored the cmake-fail-fast branch November 23, 2018 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants