Fix param set issue #670
Merged
Fix param set issue #670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using strncmp over the full char[] length instead of only over strlen we supposedly read garbage and therefore the comparison actually failed when the two char[] should have been the same. I'm assuming that std::string::compare doesn't suffer from these troubles and we the correct comparison out of the box.
This updates from version 18 to version 20 as contained in E90 v1.0.56.
JonasVautherin
approved these changes
Feb 14, 2019
|
@julianoes That would be nice, thanks. But where do I find these definition files and why would they change? |
|
They change as cameras get new features or fixes. |
|
Ideally the SDK downloads the files via http but that's currently broken through MFi on ST10C. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue reported by @douglaswsilva.
As part of this pull request I've also updated to the latest E90 camera definition file.
@Stifael or @potaito maybe you can send me the latest E50, ET, etc. camera definition files, so I can add them here.