Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Param #686

Merged
merged 9 commits into from
Mar 8, 2019
Merged

Add Param #686

merged 9 commits into from
Mar 8, 2019

Conversation

douglaswsilva
Copy link
Collaborator

@douglaswsilva douglaswsilva commented Feb 28, 2019

  • Add set and get params to wrapper.

@douglaswsilva douglaswsilva changed the title [WIP] Add params raw to wrapper. Add Param Mar 5, 2019
@JonasVautherin
Copy link
Collaborator

When building with latest develop, I get errors such as the following:

backend/src/mission/mission.grpc.pb.h:244:11: error: ‘class dronecode_sdk::rpc::mission::MissionService::Stub::experimental_async’ has pointer data members [-Werror=effc++]
     class experimental_async final :
           ^~~~~~~~~~~~~~~~~~
backend/src/mission/mission.grpc.pb.h:244:11: error:   but does not override ‘dronecode_sdk::rpc::mission::MissionService::Stub::experimental_async(const dronecode_sdk::rpc::mission::MissionService::Stub::experimental_async&)’ [-Werror=effc++]
backend/src/mission/mission.grpc.pb.h:244:11: error:   or ‘operator=(const dronecode_sdk::rpc::mission::MissionService::Stub::experimental_async&)’ [-Werror=effc++]
cc1plus: all warnings being treated as errors

I need to figure out what's happening there, sorry for the delay 😕.

julianoes
julianoes previously approved these changes Mar 7, 2019
Copy link
Collaborator

@julianoes julianoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many many changes 😄

@JonasVautherin JonasVautherin force-pushed the douglas/add_params_raw branch from fa148e4 to 5b5c256 Compare March 8, 2019 22:26
Copy link
Collaborator

@JonasVautherin JonasVautherin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @douglaswsilva!

@JonasVautherin JonasVautherin merged commit ff850d1 into mavlink:develop Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants