Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable backend to accept connection URL #730

Merged
merged 2 commits into from
Apr 28, 2019
Merged

Enable backend to accept connection URL #730

merged 2 commits into from
Apr 28, 2019

Conversation

julianoes
Copy link
Collaborator

This allows the backend_bin to be started with any connection URL.

Resolves #587.

@julianoes
backend: allow any connection to be started
3605db0 
Instead of limiting the backend to UDP connections we should enable all
possible connections using `add_any_connection()`.
JonasVautherin
JonasVautherin previously approved these changes Apr 26, 2019
View reviewed changes
Copy link
Collaborator

@JonasVautherin JonasVautherin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

NOTE: that's breaking the iOS SDK, so that's something to keep in mind for the next release there.

@julianoes
backend: add connection URL as arg to backend_bin
198bfa7 
This allows backend_bin to accept the connection URL as an argument, as
well as -h or --help to show the usage.
@julianoes julianoes force-pushed the backend-with-any-connection branch from a4f0a40 to 198bfa7 Compare April 26, 2019 13:12
@julianoes
Copy link
Collaborator Author

Ignoring CI error, took note in #731.

@julianoes
Copy link
Collaborator Author

@JonasVautherin can we merge it?

JonasVautherin
JonasVautherin approved these changes Apr 28, 2019
View reviewed changes
Copy link
Collaborator

@JonasVautherin JonasVautherin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested!

@JonasVautherin
Copy link
Collaborator

Wait, what's this error on Fedora? 😅

../../backend/test/camera_service_impl_test.cpp:436: Failure

Expected equality of these values:
  modes.size()
    Which is: 6
  received_modes.size()
    Which is: 7
Sending interrupt signal to process

I guess that's independent from this PR.

@JonasVautherin JonasVautherin merged commit 7d75c16 into develop Apr 28, 2019
@JonasVautherin JonasVautherin deleted the backend-with-any-connection branch April 28, 2019 20:22
@douglaswsilva
Copy link
Collaborator

@JonasVautherin Hey, it is indeed breaking the IOS SDK. Any Idea how we can fix it?

@JonasVautherin JonasVautherin mentioned this pull request May 6, 2019
Closed
@JonasVautherin
Copy link
Collaborator

Good point! Let's track this in the Swift SDK repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonasVautherin JonasVautherin JonasVautherin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable serial and TCP connections for backend
3 participants
@julianoes @JonasVautherin @douglaswsilva