Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

camera: add support for Yuneec E10T #757

Merged
merged 1 commit into from
Jun 11, 2019
Merged

camera: add support for Yuneec E10T #757

merged 1 commit into from
Jun 11, 2019

Conversation

darioxz
Copy link
Contributor

@darioxz darioxz commented Jun 4, 2019 •
edited
Loading

This adds support for the E10T thermal camera for the Yuneec H520.

Still needs testing.

@julianoes
Copy link
Collaborator

@darioxz thanks.

Don't forget to add it here as well:
https://github.com/Dronecode/DronecodeSDK/blob/4c8b1c1319c7208a43682720714d7c8a3b7da91a/src/plugins/camera/camera_impl.cpp#L919-L932
and here:
https://github.com/Dronecode/DronecodeSDK/blob/4c8b1c1319c7208a43682720714d7c8a3b7da91a/src/plugins/camera/CMakeLists.txt#L3-L5

@darioxz darioxz changed the title camera: add support for Yuneec E10T [WIP] camera: add support for Yuneec E10T Jun 4, 2019
@darioxz darioxz force-pushed the yuneec-e10t-support branch 2 times, most recently from 66b694f to b274801 Compare June 4, 2019 14:43
@julianoes
Copy link
Collaborator

@darioxz any idea what is missing?

ERROR: Resource file "//home/travis/build/Dronecode/DronecodeSDK/src/plugins/camera/camera_definition_files/e10t.xml" cannot be open.

@darioxz darioxz force-pushed the yuneec-e10t-support branch from b274801 to 07fa991 Compare June 6, 2019 06:00
@darioxz
Copy link
Contributor Author

darioxz commented Jun 6, 2019

@julianoes I didn't realize that there has been a reorganization of the files and copied the file to the old location. (1dde59f)

@julianoes julianoes self-requested a review June 6, 2019 13:24
julianoes
julianoes approved these changes Jun 6, 2019
View reviewed changes
Copy link
Collaborator

@julianoes julianoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me. @darioxz please remove [WIP] in the title if you want this merged.

Note that there are integration tests to test these kind of cameras.

JonasVautherin
JonasVautherin approved these changes Jun 6, 2019
View reviewed changes
Copy link
Collaborator

@JonasVautherin JonasVautherin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@julianoes julianoes changed the title [WIP] camera: add support for Yuneec E10T camera: add support for Yuneec E10T Jun 11, 2019
@julianoes julianoes merged commit b0fa994 into mavlink:develop Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julianoes julianoes julianoes approved these changes

@JonasVautherin JonasVautherin JonasVautherin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@darioxz @julianoes @JonasVautherin