Change clang-format style #790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the chosen clang format style. The main reason for this change is to work around a clang-format bug in AlignAfterOpenBracked introduced with clang-format 8: https://bugs.llvm.org/show_bug.cgi?id=41676 By changing to this option, we resolve the problem were different versions enforce different styles. Also, in my opinion this style makes more sense in general. For some argumentation by Kevlin Henney, I suggest to watch: https://youtu.be/ZsHMHukIlJY?t=1027
We wanted to switch the pointer and reference alignment style for a while. Given now we just had many automatic changes with the previous style change as well as the rename, it makes sense to do this change now. The reasoning is mostly that this is more common in C++ in general and that it is recommended by the CppCoreGuidelines. https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#nl18-use-c-style-declarator-layout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AlignAfterOpenBracket -> AlwaysBreak
The main reason for this change is to work around a clang-format bug in AlignAfterOpenBracked introduced with clang-format 8:
https://bugs.llvm.org/show_bug.cgi?id=41676
By changing to this option, we resolve the problem were different versions enforce different styles.
Also, in my opinion this style makes more sense in general.
For some argumentation by Kevlin Henney, I suggest to watch:
https://youtu.be/ZsHMHukIlJY?t=1027
PointerAlignment -> Left
We wanted to switch the pointer and reference alignment style for a while. Given now we just had many automatic changes with the previous style change as well as the rename, it makes sense to do this change
now.
The reasoning is mostly that this is more common in C++ in general and that it is recommended by the CppCoreGuidelines.
https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#nl18-use-c-style-declarator-layout
Closes #412 and fixes #321.