Add clear mission support

[douglaswsilva]

Implementation of Mission: provide API to clear mission

[julianoes]

Looks correct to me, thanks!

[julianoes]

@douglaswsilva check the Jenkins build issues though.

[JonasVautherin]

Looking clean to me as well!

Small note: we don't have the [WIP] plugin anymore, so you could open a "draft PR" instead, if you want to make sure we don't merge it 😊

[julianoes]

@douglaswsilva it would be nice if you could add the clear command to the integration test, e.g. at the end of the mission test you could clear the mission:

MAVSDK/src/integration_tests/mission.cpp

Line 252 in 0280deb

LogInfo() << "Disarmed, exiting.";

[julianoes]

I'm just trying to understand why the integration test fails:

[11:50:20|Info ] �[0mCleared mission, exiting. (mission.cpp:261)
�[34m[11:50:20�[34m|Info ] �[0mMission accepted (mission_impl.cpp:166)
�[34m[11:50:20|Info ] �[0mDownloading mission... (mission.cpp:183)
�[33m[11:50:20|Warn ] �[0mIgnoring mission request int, not active (mission_impl.cpp:109)
[11:50:20|Info ] �[0mMission uploaded. (mission.cpp:173)
�[32m[11:50:20|Debug] �[0mMAVLink: critical: IGN REQUEST LIST: Busy (system_impl.cpp:306)
�[33m[11:50:20|Warn ] �[0mIgnoring mission request int, not active (mission_impl.cpp:109)
�[33m[11:50:20|Warn ] �[0mIgnoring mission request int, not active (mission_impl.cpp:109)
�[33m[11:50:20|Warn ] �[0mIgnoring mission request int, not active (mission_impl.cpp:109)
�[33m[11:50:20|Warn ] �[0mIgnoring mission request int, not active (mission_impl.cpp:109)
�[33m[11:50:20|Warn ] �[0mIgnoring mission request int, not active (mission_impl.cpp:109)
�[33m[11:50:20|Warn ] �[0mIgnoring mission request int, not active (mission_impl.cpp:109)
�[33m[11:50:20|Warn ] �[0mRetrying requesting mission list... (mission_impl.cpp:1401)
�[32m[11:50:20|Debug] �[0mMAVLink: critical: IGN REQUEST LIST: Busy (system_impl.cpp:306)
�[33m[11:50:20|Warn ] �[0mIgnoring mission request int, not active (mission_impl.cpp:109)
�[33m[11:50:20|Warn ] �[0mIgnoring mission request int, not active (mission_impl.cpp:109)
�[33m[11:50:20|Warn ] �[0mIgnoring mission request int, not active (mission_impl.cpp:109)
�[33m[11:50:20|Warn ] �[0mIgnoring mission request int, not active (mission_impl.cpp:109)
�[33m[11:50:20|Warn ] �[0mIgnoring mission request int, not active (mission_impl.cpp:109)
�[33m[11:50:20|Warn ] �[0mIgnoring mission request int, not active (mission_impl.cpp:109)
�[33m[11:50:20|Warn ] �[0mIgnoring mission request int, not active (mission_impl.cpp:109)
�[33m[11:50:20|Warn ] �[0mRetrying requesting mission list... (mission_impl.cpp:1401)
�[33m[11:50:20|Warn ] �[0mIgnoring mission request int, not active (mission_impl.cpp:109)
�[33m[11:50:20|Warn ] �[0mIgnoring mission request int, not active (mission_impl.cpp:109)
�[33m[11:50:20|Warn ] �[0mIgnoring mission request int, not active (mission_impl.cpp:109)
�[33m[11:50:20|Warn ] �[0mIgnoring mission request int, not active (mission_impl.cpp:109)
�[33m[11:50:21|Warn ] �[0mRetrying requesting mission list... (mission_impl.cpp:1401)
�[32m[11:50:21|Debug] �[0mRequested mission item 0 (mission_impl.cpp:1007)
�[31m[11:50:21|Error] �[0mError: unknown mission ack: 1 (mission_impl.cpp:178)
�[33m[11:50:21|Warn ] �[0mCallback is not set (mission_impl.cpp:1216)
�[32m[11:50:21|Debug] �[0mMAVLink: critical: IGN REQUEST LIST: Busy (system_impl.cpp:306)
�[32m[11:50:21|Debug] �[0mMAVLink: critical: Operation timeout (system_impl.cpp:306)
�[32m[11:50:21|Debug] �[0mMAVLink: critical: WPM: REJ. CMD: Req. WP was unexpected (system_impl.cpp:306)
../../../../src/integration_tests/mission.cpp:206: Failure
Expected equality of these values:
  status
    Which is: 4-byte object <01-00 00-00>
  std::future_status::ready
    Which is: 4-byte object <00-00 00-00>
[  FAILED  ] SitlTest.MissionAddWaypointsAndFly (38327 ms)

[douglaswsilva]

@julianoes Let me know if there's anything else I need to do for the PR.

[julianoes]

Thanks for fixing this.