Extract cpp_rsc #840
Merged
Extract cpp_rsc #840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasVautherin
force-pushed
the
extract-cpp-rsc
branch
from
81a28e1
to
37c0574
Compare
|
Note: together with #839, this allows me to build for android-arm64 with dockcross (and I expect it to work for other dockcross configurations). |
julianoes
reviewed
Aug 13, 2019
src/plugins/camera/camera_definition_files/generated/camera_definition_files.cpp
Outdated
Show resolved
Hide resolved
JonasVautherin
force-pushed
the
extract-cpp-rsc
branch
from
37c0574
to
902bfc0
Compare
JonasVautherin
force-pushed
the
extract-cpp-rsc
branch
from
1bf3655
to
a0b7fc3
Compare
julianoes
approved these changes
Aug 13, 2019
| '\x76', '\x65', '\x72', '\x73', '\x69', '\x6f', '\x6e', '\x3d', '\x22', | ||
| '\x36', '\x22', '\x3e', '\x0a', '\x20', '\x20', '\x20', '\x20', '\x20', | ||
| '\x20', '\x20', '\x20', '\x3c', '\x6d', '\x6f', '\x64', '\x65', '\x6c', | ||
| '\x3e', '\x43', '\x47', '\x4f', '\x45', '\x54', '\x3c', '\x2f', '\x6d', |
There was a problem hiding this comment.
Suggested change
| '\x3e', '\x43', '\x47', '\x4f', '\x45', '\x54', '\x3c', '\x2f', '\x6d', | |
| '\x3e', '\x42', '\x47', '\x4f', '\x45', '\x54', '\x3c', '\x2f', '\x6d', |
Pretty sure! 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure how ugly this is, but:
camera_definition_files.*are now versioned#ifdefsin the code@julianoes: What do you think? I'm mainly interested in seeing if that fixes the dockcross compilation after the protoc PR is merged.