Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PR 1922 regarding EVENT message #1925

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Fix PR 1922 regarding EVENT message #1925

merged 1 commit into from
Nov 15, 2023

Conversation

Vicidel
Copy link

@Vicidel Vicidel commented Nov 15, 2023

Just realized I did not commit this fix which fixes CI for PR 1922... Sorry about that, should be good, but could you run the CI again to be sure?

@Vicidel
Copy link
Author

Vicidel commented Nov 15, 2023

Well now the build_target_workspace is not failing anymore, the one failing is run_target_test. Does not seems linked to my changes though. I'll check what I can do here

@vooon vooon added this to the Version 2.7 milestone Nov 15, 2023
vooon
vooon approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@vooon vooon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vooon vooon merged commit 2e20c1c into mavlink:ros2 Nov 15, 2023
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vooon vooon vooon approved these changes

Assignees
No one assigned
Labels
fix ros2
Projects
ROS2 support
Status: Done
Milestone
Version 2.7
Development

Successfully merging this pull request may close these issues.
2 participants
@Vicidel @vooon