Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let's drop IE11, Edge < 16, Chrome 41 #606

Closed
LeaVerou opened this issue Jun 15, 2020 · 5 comments
Closed

Let's drop IE11, Edge < 16, Chrome 41 #606

LeaVerou opened this issue Jun 15, 2020 · 5 comments

Comments

@LeaVerou
Copy link
Member

LeaVerou commented Jun 15, 2020

Now that the market share of IE combined plus old Edge is < 2%, I think it's about time to drop them in future releases. This way we can finally refactor the codebase to use async/await, and even modules one day, and it will reduce the size of our transpiled code significantly.

We can also drop Chrome 41, since Googlebot updated last year.

Useful for decisions: https://caniuse.com/usage-table

@LeaVerou LeaVerou added this to the v0.3.0 milestone Jun 15, 2020
@LeaVerou LeaVerou changed the title Let's drop IE11 and Edge < 16 Let's drop IE11, Edge < 16, Chrome 41 Jun 15, 2020
@joyously
Copy link

You basically did that already since Mavo doesn't test which version to load.
#569 (comment)

@LeaVerou
Copy link
Member Author

@joyously Support for a given browser doesn't mean every single bundle needs to support that browser, just one. Typically, browser support is up to the app developer, and they can pick an appropriate bundle. I do like your idea about loading the transpiled bundle conditionally, it would make a cool plugin.

@karger
Copy link
Collaborator

karger commented Jun 15, 2020

It is certainly irrelevant from a research perspective, and you know better about the practical/developer consequences. For clarification: you talk about transpiling in the original post; will you still generate a transpiled version that works in edge, or will it just not work at all?

@LeaVerou
Copy link
Member Author

@karger Last time I checked, async/await can't really be transpiled (the transpiled code was monstrously huge). Also, keeping the transpiled file small to serve the needs of the many is a goal as well.

@DmitrySharabin
Copy link
Member

I am all in favor. I believe the Mavo bundle size is crucial for most developers who might give Mavo a try, like it, but never use it in production because of its size. And if we can make it smaller, I’m in.

LeaVerou added a commit that referenced this issue Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants