Insert Mavo bar in <body> if Mavo root is on <html> fixes #830
#949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeaVerou
requested changes
Jan 21, 2023
There was a problem hiding this comment.
Hi there, thanks for contributing!
Please do not modify old versions in dist/. These are archival and should never be modified.
@DmitrySharabin can we update CONTRIBUTING.md to mention this? It's the 2nd time this happened.
Wrt the actual code change, LGTM.
|
Sorry, I didn't notice. It was my bad. Just Updated the present version. |
LeaVerou
changed the title
<body> if Mavo root is on <html> fixes #830
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let me know If there is any mistake in my contribution as I'm new to open-source contributions. Thank you.