ConfigExtensions: Tolerate implementation and breaking API changes in BDN #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
mawosoft
commented
Feb 15, 2022
•
mawosoft
commented
- Tolerate implementation changes in ManualConfig.GetXxx() Closes ManualConfig.GetLogicalGroupRules() becomes List<> instead of HashSet<> #25.
- Tolerate breaking API changes in BenchmarkReport.ctor() and others. See Breaking changes in BDN-nightly #27.
- Unpin NightlyBDN (Issue resolved PR builds should not be published to BDN nightly feed dotnet/BenchmarkDotNet#1922).
- Add tests.
…es in BDN-nightly > 0.13.1. - Tolerate implementation changes in ManualConfig.GetXxx() Closes #25. - Tolerate breaking API changes in BenchmarkReport.ctor() and others. See #26. - Unpin NightlyBDN (Issue resolved dotnet/BenchmarkDotNet#1922). - Add tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.