Check if file exists before loading editorconfig settings #3018
Conversation
|
Hello, does this PR seem reasonable? |
rc/detection/editorconfig.kak
Outdated
| print "autowrap-enable" | ||
| print "add-highlighter window/ column %sh{ echo $((" max_line_length "+1)) } default,bright-black" | ||
| file="${1:-$kak_buffile}" | ||
| if [ -f "$file" ]; then |
There was a problem hiding this comment.
| if [ -f "$file" ]; then | |
| if [ -e "$file" ]; then |
To handle symlinks.
|
Hello, I dont think the logic should be to disable editorconfig for non-existing files, what we want is to disable it for non-file buffers (scratch buffers in Kakoune lingo). One distinction between file and non-file buffers is that $kak_buffile will be an absolute path for any file buffer, but just match the buffer name for a non-file buffer, so I suspect ignoring all buffers where $kak_buffile does not start with a slash would do the trick. EDIT: Also, sorry for the delay in taking a look at that. |
Check if buffile is a full path by checking for the beginning
'/' character in editorconfig-load command. This avoids a parsing
error from feeding a *scratch*/*debug*/*grep*/etc. buffer name to the
editorcofig command. Don't clear editorconfig hooks until after checking
for a valid bufffile path. This way, opening the *debug* buffer will
not clear the hooks from a previously parsed .editorconfig file. If
trim_trailing_whitespace is true, print the hook directly from awk. This
removes the need to save a editorcofig_trim_trailing_whitespace option.
Note: Setting the max_line_length requires a window to be created.
Therefore, a global hook to load .editorconfig settings should be:
hook global WinCreate .* %{editorconfig-load}
|
I've updated this PR to check if As mawww suggested, this should work for all unix environments. On Cygwin, it appears you can specify a path that begins with a drive letter (ex: Lastly, if you want to keep the editorconfig.kak script as-is. I've been using a WinCreate hook with regex to filter out buffer names that start with a |
I noticed when using the recommended editorconfig hook from the Wiki, that the editorconfig.kak script failed for buffers that were not real files. For example
*scratch*,*debug*,*make*,*grep*, etc.This PR adds a check in the
editorcofig-loadcommand to see if a file exists before calling the externaleditorconfigutility.It also moves the
remove-hooksline to after the valid file check and directly prints the command to add a remove trailing whitespace hook from awk (if necessary). This prevents an invalid file from clearing a hook and removes the need to store an option and reference it from a spawned shell in the later hook.