A 'c' column suffix selects by codepoints #3188
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2724
This only selects by codepoints right now. If this approach is acceptable, I'll add support for a
d
suffix for display columns.This only allows codepoint-based selection for the most recent timestamp on a buffer. Adding support for historic timestamps will be quite tricky, but I'm willing to do it if we have a use case (or a compelling reason).
The test should be comprehensive, starting and ending on a single-byte char, a multi-byte char, selecting only a combining character, the main character plus a subset of combining characters, having a reverse selection. I was worried about failure on interesting cases - but none of them turned out to need more work, surprisingly. I'm happy to add test cases if I missed anything.