Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace callback-style API with Promise-style API #90

Merged
merged 12 commits into from
Mar 25, 2020
Merged

Conversation

malept
Copy link
Collaborator

@malept malept commented Mar 25, 2020

BREAKING CHANGE: drops callback-style support in favor of a Promises-based API. If you still need callback-style support, see util.callbackify.

Additional changes:

  • Refactor the code so that's it's encapsulated in a class, instead of in one monolithic function (with nested functions)
  • More modern Node refactors
  • Replace tape with ava
  • Replace concat-stream with get-stream
  • The code base should have full test coverage now

Fixes #81
Closes #46

@malept malept merged commit af00186 into master Mar 25, 2020
@malept malept deleted the promisify branch March 25, 2020 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Promise support
1 participant